Fix/backend/strict null check #279

usatie · 2024-02-21T07:15:07Z

デプロイ先でこのエラーが起きていて、おや？と思ったところからstrictNullCheckがされていないことに気づいた
ONにしてみたら約60個エラーが出たので一応全部消しておいたというやつです

coderabbitai · 2024-02-21T07:15:19Z

Warning

Rate Limit Exceeded

@usatie has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 20 minutes and 9 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between 53624f0 and 7b17a76.

Walkthrough

The recent update aims to enhance various aspects of the backend to improve chat functionality. Changes include refining user validity checks, upgrading error handling, and enhancing code clarity. Additionally, optional chaining in the ChatService now safely accesses the name property of the client object.

Changes

File(s)	Summary
`backend/prisma/seed.ts`	Refactored `seedFriends` function to use `Array.map` for updating user friends, altering how user connections are managed.
`backend/src/auth/auth.service.ts`	- Added constants and improved error handling. - Refactored code to use constants for client ID, client secret, and public URL. - Enhanced 2FA logic and error handling.
`backend/src/events/events.gateway.ts`	Changed return types to `Promise<void` and added opponent check for game status updates.
`backend/src/main.ts`	Introduced a constant for port configuration with a fallback to 3000 if `process.env.PORT` is undefined.
`backend/src/room/ban/ban.service.ts` `backend/src/room/mute/mute.service.ts`	Updated `create` method to use `findUniqueOrThrow` for room retrieval based on `roomId`.
`backend/src/room/entities/room.entity.ts`	Modified `password` property to allow `null` values for a nullable password field.
`backend/src/room/guards/enter-room.guard.ts`	Added check to ensure `room.password` is defined before password validation.
`backend/src/room/room.service.ts`	Updated return types to `Room` and adjusted import statements and method signatures.
`backend/src/user/entities/public-user.entity.ts` `backend/src/user/entities/user.entity.ts`	Changed `password` property to `string

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit-tests for this file.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit tests for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository from git and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit tests.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
The JSON schema for the configuration file is available here.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

- Naming consistency - Use match request instead of invite

coderabbitai · 2024-02-21T17:29:26Z

backend/src/chat/entities/message.entity.ts

+export class WsPublicUserEntity {
+  constructor(user: WsPublicUserEntity) {
+    this.id = user.id;
+    this.name = user.name;
+    this.avatarURL = user.avatarURL;
  }
  id: number;
  name: string;
-  avatarURL?: string;
+  avatarURL: string | null;


The constructor of WsPublicUserEntity takes an instance of its own class as a parameter, which seems unusual for typical use cases. This pattern might be intended for cloning instances, but if that's not the case, it could lead to confusion or misuse. Consider revising the constructor's parameter to match the intended use case, such as accepting raw user data instead.

確かに。まー引数にはPrismaのUserを取っておくか。

@usatie: 確かに、PrismaのUser型をコンストラクタの引数として使用する提案は、初期のコメントで提起された懸念に直接対処します。この変更により、コンストラクタの目的がより明確になり、データベースからの生データを使ってエンティティを初期化するという一般的な使用例に合致します。この方向での修正がコードの明確性と使いやすさを向上させるでしょう。もし追加でサポートや説明が必要であれば、お知らせください。

- because the properties are required, it should not use PartialType

coderabbitai · 2024-02-21T22:04:42Z

backend/src/room/dto/update-UserOnRoom.dto.ts

 import { CreateUserOnRoomDto } from './create-UserOnRoom.dto';

-export class UpdateUserOnRoomDto extends PartialType(CreateUserOnRoomDto) {}
+export class UpdateUserOnRoomDto extends CreateUserOnRoomDto {}


Directly extending CreateUserOnRoomDto in UpdateUserOnRoomDto without using PartialType means all properties from the base DTO are required, which might not align with typical update operation needs where partial updates are common. Consider using PartialType or an equivalent approach to make properties optional, enhancing flexibility for update operations.

CreateUserOnRoomがここでしか使われてなかったので存在する必要なかったので、CreateUserOnRoomの定義をそのままこっちに持ってきた。

@usatie: 了解しました。CreateUserOnRoomDtoが特定のコンテキストでのみ使用されているとのことで、その定義をUpdateUserOnRoomDtoに直接統合することは理にかなっています。この変更がPRの目的に沿っており、コードベースの柔軟性や保守性を損なわないことを確認することが重要です。変更がプロジェクト全体の品質と安定性向上に寄与することを期待しています。

New Learnings Added

User: usatie PR: usatie/pong#279 File: backend/src/room/dto/update-UserOnRoom.dto.ts:0-0 Timestamp: 2024-02-21T23:40:40.188Z Learning: `CreateUserOnRoomDto` is only used in the context of `UpdateUserOnRoomDto` and its definition has been merged directly into `UpdateUserOnRoomDto`.

Note: Learnings are effective only in the context of specific code segments. To apply general coding guidelines, please configure path-based instructions.

- Align with the prisma schema

- To align with prisma schema - But it is not desirable to have nullable password field

usatie added 5 commits February 21, 2024 08:02

[backend] Enable strictNullChecks in tsconfig.json

86d8e98

[backend] Fix handleDisconnect to handle null user

00c8a15

[backend] Fix MessageEntity constructor by strict null check

f8cd939

[backend] Fix WsPublicUserEntity constructor by using the correct type

a763fe3

[backend] Fix match request handlers

f4f47c5

- Naming consistency - Use match request instead of invite

usatie force-pushed the fix/backend/strict-null-check branch from 95aeabf to f4f47c5 Compare February 21, 2024 17:27

coderabbitai bot reviewed Feb 21, 2024

View reviewed changes

[backend] Fix UpdateUserOnRoomDto to not use PartialType

702ec41

- because the properties are required, it should not use PartialType

coderabbitai bot reviewed Feb 21, 2024

View reviewed changes

usatie added 12 commits February 21, 2024 14:32

[backend] Fix RoomEntity password type to be nullable

9b3678c

- Align with the prisma schema

[backend] Fix UserEntity password type to be nullable

ba7f74a

- To align with prisma schema - But it is not desirable to have nullable password field

[backend] Fix PublicUserEntity password type to be nullable

0959b62

[backend] Fix mute and ban services to use findUniqueOrThrow

3400425

[backend] Fix strict null check in enter-room.guard.ts

85a2a0a

[backend] Fix strict null check for events.gateway.ts

c478ea3

[backend] Fix strict null check in auth service

6e5ff80

[backend] Fix strict null check in seed.ts

d64033f

[backend] Fix strict null check in main.ts

5751add

[backend] Fix strict null check in events.gateway.ts

8efb0c4

[backend] Fix WsPublicUserEntity constructor

53624f0

[backend] Remove CreateUserOnRoomDto (which is not used)

7b17a76

usatie merged commit c5c6495 into main Feb 21, 2024
4 checks passed

usatie deleted the fix/backend/strict-null-check branch February 21, 2024 23:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix/backend/strict null check #279

Fix/backend/strict null check #279

usatie commented Feb 21, 2024 •

edited

Loading

coderabbitai bot commented Feb 21, 2024 •

edited

Loading

Rate Limit Exceeded

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

CodeRabbit Discord Community

coderabbitai bot Feb 21, 2024 •

edited

Loading

usatie Feb 21, 2024

coderabbitai bot Feb 21, 2024

coderabbitai bot Feb 21, 2024 •

edited

Loading

usatie Feb 21, 2024

coderabbitai bot Feb 21, 2024

Fix/backend/strict null check #279

Fix/backend/strict null check #279

Conversation

usatie commented Feb 21, 2024 • edited Loading

coderabbitai bot commented Feb 21, 2024 • edited Loading

Rate Limit Exceeded

Walkthrough

Changes

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

CodeRabbit Discord Community

coderabbitai bot Feb 21, 2024 • edited Loading

Choose a reason for hiding this comment

usatie Feb 21, 2024

Choose a reason for hiding this comment

coderabbitai bot Feb 21, 2024

Choose a reason for hiding this comment

coderabbitai bot Feb 21, 2024 • edited Loading

Choose a reason for hiding this comment

usatie Feb 21, 2024

Choose a reason for hiding this comment

coderabbitai bot Feb 21, 2024

Choose a reason for hiding this comment

usatie commented Feb 21, 2024 •

edited

Loading

coderabbitai bot commented Feb 21, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)

coderabbitai bot Feb 21, 2024 •

edited

Loading

coderabbitai bot Feb 21, 2024 •

edited

Loading